Remove two TODO list items that don't apply.
Johnny C. Lam [03-29-13 - 01:57]
Remove two TODO list items that don't apply.
* IsSpellInRange() doesn't take spell IDs.
* Extending the grammar to allow function calls to be used as parameters
for other functions is a parser issue that is part of ticket #181.
git-svn-id: svn://svn.curseforge.net/wow/ovale/mainline/trunk@852 d5049fe3-3747-40f7-a4b5-f36d6801af5f
diff --git a/OvaleCondition.lua b/OvaleCondition.lua
index 2f70f4e..898fb97 100644
--- a/OvaleCondition.lua
+++ b/OvaleCondition.lua
@@ -1489,8 +1489,7 @@ end
-- Spell(kick)
OvaleCondition.conditions.inrange = function(condition)
- --TODO is IsSpellInRange using spell id now?
- local spellName = API_GetSpellInfo(condition[1])
+ local spellName = OvaleData:GetSpellName(condition[1])
return testbool(API_IsSpellInRange(spellName, getTarget(condition)) == 1,condition[2])
end
@@ -2683,7 +2682,6 @@ OvaleCondition.conditions.deadin = OvaleCondition.conditions.timetodie
-- if TimeInToMaxEnergy(less 1.2) Spell(sinister_strike)
OvaleCondition.conditions.timetomaxenergy = function(condition)
--- TODO: temp, need to allow function calls in functions call to do things link TimeTo(Energy() == 100) which would be TimeTo(Equal(Energy(), 100))
local maxEnergy = API_UnitPowerMax("player", OVALE_POWERTYPE_ENERGY) or 0
local t = OvaleState.currentTime + (maxEnergy - OvaleState.state.energy) / OvaleState.powerRate.energy
return 0, nil, 0, t, -1