Quantcast

Removed some localized globals that didn't really need to be.

torhal [11-21-09 - 11:42]
Removed some localized globals that didn't really need to be.
In the OnClick script for ARL_ResetButton: Replaced individual class toggles with iterative toggles, and a call to UnitClass("player") with Player["Class"]. Also removed the setting of a non-existent filter.
Filename
ARLFrame.lua
diff --git a/ARLFrame.lua b/ARLFrame.lua
index adf7b8c..3a2c301 100644
--- a/ARLFrame.lua
+++ b/ARLFrame.lua
@@ -56,11 +56,6 @@ local GetTradeSkillLine = GetTradeSkillLine
 local GetItemInfo = GetItemInfo
 local UnitClass = UnitClass

-local IsModifierKeyDown = IsModifierKeyDown
-local IsShiftKeyDown = IsShiftKeyDown
-local IsAltKeyDown = IsAltKeyDown
-local IsControlKeyDown = IsControlKeyDown
-
 -------------------------------------------------------------------------------
 -- AddOn namespace.
 -------------------------------------------------------------------------------
@@ -2661,41 +2656,31 @@ function addon:InitializeFrame()
 	local ARL_ResetButton = GenericCreateButton("ARL_ResetButton", MainPanel,
 						    25, 90, "TOPRIGHT", ARL_FilterButton, "BOTTOMRIGHT", 0, -2, "GameFontNormalSmall",
 						    "GameFontHighlightSmall", L["Reset"], "CENTER", L["RESET_DESC"], 1)
-	ARL_ResetButton:SetScript("OnClick", function()
-						     local filterdb = addon.db.profile.filters
-
-						     -- Reset all filters to true
-						     recursiveReset(addon.db.profile.filters)
-
-						     -- Reset specific filters to false
-						     filterdb.general.class = false
-						     filterdb.general.specialty = false
-						     filterdb.general.known = false
-
-						     -- Reset all classes to false
-						     filterdb.classes.deathknight = false
-						     filterdb.classes.druid = false
-						     filterdb.classes.hunter = false
-						     filterdb.classes.mage = false
-						     filterdb.classes.paladin = false
-						     filterdb.classes.priest = false
-						     filterdb.classes.rogue = false
-						     filterdb.classes.shaman = false
-						     filterdb.classes.warlock = false
-						     filterdb.classes.warrior = false
-
-						     -- Set your own class to true
-						     local _, currentclass = UnitClass("player")
-
-						     filterdb.classes[strlower(currentclass)] = true
-
-						     if MainPanel:IsVisible() then
-							     MainPanel:UpdateTitle()
-							     HideARL_ExpOptCB()
-							     addon.Flyaway:Hide()
-							     ReDisplay()
-						     end
-					     end)
+	ARL_ResetButton:SetScript("OnClick",
+				  function()
+					  local filterdb = addon.db.profile.filters
+
+					  -- Reset all filters to true
+					  recursiveReset(addon.db.profile.filters)
+
+					  -- Reset specific filters to false
+					  filterdb.general.specialty = false
+					  filterdb.general.known = false
+
+					  -- Reset all classes to false
+					  for class in pairs(filterdb.classes) do
+						  filterdb.classes[class] = false
+					  end
+					  -- Set your own class to true
+					  filterdb.classes[strlower(Player["Class"])] = true
+
+					  if MainPanel:IsVisible() then
+						  MainPanel:UpdateTitle()
+						  HideARL_ExpOptCB()
+						  addon.Flyaway:Hide()
+						  ReDisplay()
+					  end
+				  end)
 	ARL_ResetButton:Hide()

 	-------------------------------------------------------------------------------