From a323301eb05a70eab4eeee27ea3f56492b096f3f Mon Sep 17 00:00:00 2001 From: Alar of Daggerspine Date: Wed, 26 Nov 2014 13:35:17 +0100 Subject: [PATCH] Fixed: Solves a rare case of library incompatibility causing error ...rfaceGarrisonCommander\GarrisonCommander-1.1.1.lua:47: attempt to call method 'capitalize' (a nil value) Feature: Removed signature in tooltip... i was annoying me too.. :) Signed-off-by: Alar of Daggerspine --- CHANGELOG.txt | 3 +++ GarrisonCommander.lua | 12 ++++++------ GarrisonCommander.toc | 2 +- RelNotes.lua | 6 +++++- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index c406df3..f747204 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,4 +1,7 @@ = GarrisonCommander helps you when choosing the right follower for the right mission = +* 1.1.2 +Fixed: Solves a rare case of library incompatibility causing error ...rfaceGarrisonCommander\GarrisonCommander-1.1.1.lua:47: attempt to call method 'capitalize' (a nil value) +Feature: Removed signature in tooltip... i was annoying me too.. :) * 1.1.1 Fix for those who has MasterPlan installed. Master Plan was breaking GarrisonCommander, this patch fixes it * 1.1.0 diff --git a/GarrisonCommander.lua b/GarrisonCommander.lua index c326bc7..b8f75fe 100644 --- a/GarrisonCommander.lua +++ b/GarrisonCommander.lua @@ -44,13 +44,13 @@ local GARRISON_FOLLOWERS=GARRISON_FOLLOWERS -- "Followers" local AVAILABLE=AVAILABLE -- "Available" local PARTY=PARTY -- "Party" local ENVIRONMENT_SUBHEADER=ENVIRONMENT_SUBHEADER -- "Environment" -local SPELL_TARGET_TYPE4_DESC=SPELL_TARGET_TYPE4_DESC:capitalize() -- party member -local SPELL_TARGET_TYPE1_DESC=SPELL_TARGET_TYPE1_DESC:capitalize() -- any +local SPELL_TARGET_TYPE4_DESC=strupper(strlower(SPELL_TARGET_TYPE4_DESC)) -- party member +local SPELL_TARGET_TYPE1_DESC=strupper(strlower(SPELL_TARGET_TYPE1_DESC)) -- any local ANYONE='('..SPELL_TARGET_TYPE1_DESC..')' local IGNORE_UNAIVALABLE_FOLLOWERS=IGNORE.. ' ' .. UNAVAILABLE .. ' ' .. GARRISON_FOLLOWERS local IGNORE_UNAIVALABLE_FOLLOWERS_DETAIL=IGNORE.. ' ' .. GARRISON_FOLLOWER_INACTIVE .. ',' .. GARRISON_FOLLOWER_ON_MISSION ..',' .. GARRISON_FOLLOWER_WORKING.. ','.. GARRISON_FOLLOWER_EXHAUSTED .. ' ' .. GARRISON_FOLLOWERS -IGNORE_UNAIVALABLE_FOLLOWERS=IGNORE_UNAIVALABLE_FOLLOWERS:capitalize() -IGNORE_UNAIVALABLE_FOLLOWERS_DETAIL=IGNORE_UNAIVALABLE_FOLLOWERS_DETAIL:capitalize() +IGNORE_UNAIVALABLE_FOLLOWERS=strupper(strlower(IGNORE_UNAIVALABLE_FOLLOWERS)) +IGNORE_UNAIVALABLE_FOLLOWERS_DETAIL=strupper(strlower(IGNORE_UNAIVALABLE_FOLLOWERS_DETAIL)) local GameTooltip=GameTooltip local timers={} function addon:AddLine(icon,name,status,r,g,b,...) @@ -251,8 +251,8 @@ function addon:TooltipAdder(missionID) --@end-debug@ end -- Add a signature - local r,g,b=C:Silver() - GameTooltip:AddDoubleLine("GarrisonCommander",self.version,r,g,b,r,g,b) + --local r,g,b=C:Silver() + --GameTooltip:AddDoubleLine("GarrisonCommander",self.version,r,g,b,r,g,b) self:DelTable(added) --@debug@ --DevTools_Dump(fellas) diff --git a/GarrisonCommander.toc b/GarrisonCommander.toc index 5dd8c72..04f605a 100644 --- a/GarrisonCommander.toc +++ b/GarrisonCommander.toc @@ -4,7 +4,7 @@ ## Notes-itIT: Ti aiuta a scegliere il giusto seguace per la giusta missione ## Author: Alar of Daggerspine ## Version: @project-version@ @project-abbreviated-hash@ -## X-Version: 1.1.1 +## X-Version: 1.1.2 ## X-Revision: @project-abbreviated-hash@ ## eMail: alar@aspide.it ## URL: http://wow.aspide.it diff --git a/RelNotes.lua b/RelNotes.lua index 354da43..1e07d26 100644 --- a/RelNotes.lua +++ b/RelNotes.lua @@ -20,7 +20,11 @@ GarrisonCommander adds to mission tooltips the following informations: == Future plans == # Improving selection of followers for missions ]]) -self:RelNotes(1,1,0,[[ +self:RelNotes(1,1,2,[[ +Fixed: Solves a rare case of library incompatibility causing error ...rfaceGarrisonCommander\GarrisonCommander-1.1.1.lua:47: attempt to call method 'capitalize' (a nil value) +Feature: Removed signature in tooltip... i was annoying me too.. :) +]]) +self:RelNotes(1,1,2,[[ Fixed: Added workaround to avoid that MasterPlan steals tooltip de facto disabling GarrisonCommander ]]) -- 1.7.9.5